search

kisom / pypcapfile

Pure Python library for handling libpcap savefiles.
http://kisom.github.com/pypcapfile
ISC License
76 stars 33 forks source link

Wi-Fi Support #22

Closed kivanccakmak closed 8 years ago

kivanccakmak commented 8 years ago

Hi there,

I added partially parsing for Wi-Fi packets, to use library with "wirelessly" sniffed data. Data packet and most frequently used control packets (RTS, CTS and acknowledgements) is detailly added now. For others, only identifying is handled.

kisom commented 8 years ago

@kivanccakmak There are merge conflicts with this (and it appears there are no tests). Can you clean up the merge conflicts, squash the commits, and add tests? Thanks!

kivanccakmak commented 8 years ago

@kisom sure, I would.

codecov-io commented 8 years ago

Current coverage is 85.67% (diff: 89.36%)

Merging #22 into master will increase coverage by 3.56%

@@             master        #22   diff @@
==========================================
  Files            13         15     +2   
  Lines           531       1047   +516   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            436        897   +461   
- Misses           95        150    +55   
  Partials          0          0

Powered by Codecov. Last update 916b484...1ff8efb

kivanccakmak commented 8 years ago

@kisom I added unit tests and run, also solved conflicts. Now, how shall I squash commits, since I pushed them on my forked repo. Shall I create new pull request with single commit and all existing (and non conflicting:) changes? Thanks.

kisom commented 8 years ago

Obsoleted by #23.