search

kisom / pypcapfile

Pure Python library for handling libpcap savefiles.
http://kisom.github.com/pypcapfile
ISC License
76 stars 33 forks source link

Adding a file length option and documentation to iterate over packets #27

Closed shealutton closed 7 years ago

shealutton commented 7 years ago

Kisom, thanks for writing this lib. It was really helpful for me, but I needed a way to iterate over 20 million packets and pull raw data out of the payload. I added a length option and some documentation on how to read over every packet to the README. Would you incorporate this into your distribution? Thanks, Shea

codecov-io commented 7 years ago

Current coverage is 85.83% (diff: 100%)

Merging #27 into master will increase coverage by 0.03%

@@             master        #27   diff @@
==========================================
  Files            15         15          
  Lines          1218       1221     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1045       1048     +3   
  Misses          173        173          
  Partials          0          0

Powered by Codecov. Last update 2c168ad...d0ea218

kisom commented 7 years ago

Hello @shealutton --- this looks really useful! One question: can you add a test for this (and optionally, your name to the AUTHORS file)?

shealutton commented 7 years ago

Yes, I will do it next week when I am on vacation @kisom .

shealutton commented 7 years ago

@kisom This was my first try at using this style of test code, please take a look and confirm that my test is legit and works the way I expect. ;) I think it is good though. I also incremented the minor version number, please make sure you agree with that change too. Thanks, Shea