search

kisom / pypcapfile

Pure Python library for handling libpcap savefiles.
http://kisom.github.com/pypcapfile
ISC License
76 stars 33 forks source link

Fix the test suite (or rather, the code) for Python 3 #35

Closed asergi closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #35 into master will decrease coverage by -0.17%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   85.83%   85.66%   -0.17%     
==========================================
  Files          15       15              
  Lines        1221     1221              
==========================================
- Hits         1048     1046       -2     
- Misses        173      175       +2
Impacted Files Coverage Δ
pcapfile/protocols/network/ip.py 79.12% <ø> (ø) :white_check_mark:
pcapfile/test/protocols_transport_tcp.py 90% <100%> (ø) :white_check_mark:
pcapfile/protocols/linklayer/wifi.py 86.08% <100%> (-0.35%) :x:
pcapfile/protocols/transport/tcp.py 71.79% <50%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f156e5...1b0bf06. Read the comment docs.

asergi commented 7 years ago

Unfortunately, 69d970a7773a6abb9ef13f88cff10f3ad278bda4 breaks Python 3 again 😞

asergi commented 7 years ago

Fixed in 106b33f6c423aa3d72f0573c0838e58557073812.