search

kisom / pypcapfile

Pure Python library for handling libpcap savefiles.
http://kisom.github.com/pypcapfile
ISC License
76 stars 33 forks source link

WIP: Fail build on failing tests #49

Closed Don42 closed 5 years ago

Don42 commented 5 years ago

This is work in progress, but since the change only shows in CI I created this PR.

Fixes #48

Don42 commented 5 years ago

The good news, builds now fail on test failures. The bad news, tests on PyPy have been failing for quite a while. I'm still unsure what the root cause for that is.

[1] https://travis-ci.org/kisom/pypcapfile/jobs/156608786

kisom commented 5 years ago

Looking at the error messages, I think that pypy is trying to do a buffered read on the savefile, and therefore it's not actually reading the header. I can try to fix this later.

Don42 commented 5 years ago

If found the issue. Pypy does not write to the file when it is not properly closed. I got a fix and will add that now.

codecov-io commented 5 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.07%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   78.35%   78.28%   -0.08%     
==========================================
  Files          16       16              
  Lines        1603     1607       +4     
==========================================
+ Hits         1256     1258       +2     
- Misses        347      349       +2
Impacted Files Coverage Δ
pcapfile/test/savefile_test.py 94.02% <100%> (+0.09%) :arrow_up:
pcapfile/test/__main__.py 94.44% <75%> (-5.56%) :arrow_down:
pcapfile/savefile.py 78.46% <0%> (-0.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eef972...d7f191f. Read the comment docs.

kisom commented 5 years ago

Thanks again, @Don42!