search

kisslinux / kiss

KISS Linux - Package Manager
https://kisslinux.github.io
MIT License
464 stars 62 forks source link

Issue downloading some packages with new sources parsing #242

Closed dilyn-corner closed 3 years ago

dilyn-corner commented 3 years ago

This is just a super cute little bug that exists for... A single package, due to dubious naming choices by the developer.

Caused by https://github.com/kisslinux/kiss/blob/b7b57bd34caf2135f8fe6c940a4a9d554ac0f365/kiss#L337

Problematic package is libsodium https://github.com/kiss-community/community/blob/main/community/libsodium/sources

It's a literal "RELEASE", not to be substituted. I'd probably just rename RELEASE to EPOCH or RELVER.

dylanaraps commented 3 years ago

Oh that's funny!

On it.

dylanaraps commented 3 years ago

There are other download URLs here for reference: https://download.libsodium.org/libsodium/releases/

Example: https://download.libsodium.org/libsodium/releases/libsodium-1.0.18.tar.gz

dylanaraps commented 3 years ago

Pushed a different fix. Kept RELEASE as-is, added ability to start a source with raw: to disable all marker replacements. Also, there's a workable source above. If many conflict issues with URLs exist, we can look into making the markers more unique (I don't think this will be the case). The raw: addition also gives users the means to make a source work despite conflict issues with markers (if they occur).

dilyn-corner commented 3 years ago

Thanks Dylan!

dylanaraps commented 3 years ago

I'll look into how feasible \MARKER is for problematic sources (ie, simple escaping rather than ugly raw:) (Then things can remain fully functional in all cases - just escape the conflicting marker and the others will work).

dylanaraps commented 3 years ago

Added support for escaping markers, see: https://github.com/kisslinux/kiss/commit/83c88b4222f1787ed4f9f05061a5e583ee7b45ce