kisslinux / kiss

KISS Linux - Package Manager
https://kisslinux.github.io
MIT License
464 stars 62 forks source link

kiss: make KISS_FORCE bypass build dependency checks #305

Closed aabacchus closed 6 months ago

aabacchus commented 2 years ago

Perhaps this is not desired, or it should use a different environment variable, but it confused me that KISS_FORCE=1 skips dependency checks for kiss i and kiss r, but not kiss b.

I would find this useful, for example, when testing building against a different provider of a library or testing if a dependency is unneeded. It's easy to work around without this by editing the depends file though.

Thoughts?

dilyn-corner commented 2 years ago

It should skip nonmake deps IMHO

Aug 7, 2022, 2:58 PM by @.***:

Perhaps this is not desired, or it should use a different environment variable, but it confused me that KISS_FORCE=1 skips dependency checks for kiss i and kiss r, but not kiss b.

I would find this useful, for example, when testing building against a different provider of a library or testing if a dependency is unneeded. It's easy to work around without this by editing the depends file though.

Thoughts?

You can view, comment on, or merge this pull request online at:

  > https://github.com/kisslinux/kiss/pull/305

Commit Summary 4c4f339 https://github.com/kisslinux/kiss/pull/305/commits/4c4f33913890b98f346ed5c29a23f2154a495e2f> kiss: make KISS_FORCE bypass build dependency checks File Changes

(> 1 file https://github.com/kisslinux/kiss/pull/305/files> )

M> > kiss https://github.com/kisslinux/kiss/pull/305/files#diff-89d19d63941a517f4921ec8496fbf07c4b444537352cc585461a1b4de469fde5> (2) Patch Links: https://github.com/kisslinux/kiss/pull/305.patch https://github.com/kisslinux/kiss/pull/305.diff

— Reply to this email directly, > view it on GitHub https://github.com/kisslinux/kiss/pull/305> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AEVM3SLIUWX2ZZDR47TM5YDVYABNLANCNFSM55244RYQ> . You are receiving this because you are subscribed to this thread.> Message ID: > <kisslinux/kiss/pull/305> @> github> .> com>

aabacchus commented 2 years ago

It should skip nonmake deps IMHO

I get that this would make sense, but it adds a bit of complexity to a) the code and b) the behaviour of KISS_FORCE. It seems to me that KISS_FORCE is an override, and so it would make sense to override everything.