search

kisslinux / repo

KISS Linux - Official Repositories
https://kisslinux.github.io
MIT License
400 stars 100 forks source link

firefox{,-beta}: enable nss build with Clang integrated assembler #310

Closed konimex closed 3 years ago

konimex commented 3 years ago

Since version 10.0 (or whatever version when Clang is able to build the kernel with using LLVM_IAS=1), the CFLAGS -no-integrated-assembler is not really needed anymore. We mainly use sed calls to remove the flags (like nodejs).

dylanaraps commented 3 years ago

Will push these changes once Firefox 91 comes out. Thanks.

dilyn-corner commented 3 years ago

If the firefox build system doesn't make use of gyp, you can probably forgo two of these three sed calls.

konimex commented 3 years ago

I'll probably stay on the safe side since 1. the current Firefox build system is a mess, and 2. nodejs (i.e. gyp) is already a build dep, and Makefiles are considered legacy in the NSS build file. (https://github.com/nss-dev/nss#building-nss) so I won't risk 40mins of building something just for it to fail.

dylanaraps commented 3 years ago

Konimex would be correct: https://bugzilla.mozilla.org/show_bug.cgi?id=1295937 (This is also where the -no-integrated-as flag was introduced).