search

kisslinux / repo

KISS Linux - Official Repositories
https://kisslinux.github.io
MIT License
400 stars 100 forks source link

mpv: missing dependency libxkbcommon #353

Closed Vouivre closed 2 years ago

Vouivre commented 2 years ago

I think libxkbcommonshould be added as a dependency of mpv.

It's possible to run mpvin the framebuffer. I have tested on my system and it works with

mpv --gpu-context=drm <name_of_video>

Normally libxkbcommonis installed because the user install sway. On a system without sway, the build of mpvshould fail. I have a system with sway, so I can't confirm the build will fail.

Another reason is in a chroot. I use a chroot to check the dependencies of my packages. If mpvhas to be build in a chroot, for example for the package in community ytfzf, the build of mpv fails. In this case, libxcommon has to be installed in order to build mpv. I have build mpvin a chroot, so I can confirm it fails.

dylanaraps commented 2 years ago

Sounds reasonable. Thanks for opening the issue.