search

kisslinux / repo

KISS Linux - Official Repositories
https://kisslinux.github.io
MIT License
400 stars 101 forks source link

`curl` doesn't compile when brotli is available #361

Closed Riteo closed 2 years ago

Riteo commented 2 years ago

For some reason curl fails with the following error when brotli is available:

/usr/bin/ld: cannot find -lbrotlidec
collect2: error: ld returned 1 exit status

Adding --without-brotli to the call to ./configure in build solves the problem.

I see you've disabled quite a lot of compression methods too, is it because they face a similar error? Is this error caused in the first place by the hacky way of compiling it statically implemented in the first few lines of build?

dylanaraps commented 2 years ago

I see you've disabled quite a lot of compression methods too, is it because they face a similar error?

Only zstd is disabled? No such error.

Is this error caused in the first place by the hacky way of compiling it statically implemented in the first few lines of build?

The "hack" just adds -all-static to the linker flags for the curl binary. The issue seems to be this: https://github.com/google/brotli/issues/795

Riteo commented 2 years ago

Only zstd is disabled? No such error.

Oh sorry, I thought I had seen more of them.

Regarding the issue I didn't know it was upstream, thanks for investigating!