kisslorand / BTT-TFT-FW

Precompiled FW for Bigtreetech TFTs and compatible MKS TFTs
20 stars 3 forks source link

Thumbnails disappearing when browsing through files. #7

Closed discip closed 11 months ago

discip commented 11 months ago

As I'm using thumbnails I noticed that they disappear if you go to the next page and only come back after the drive was excited and re-entered.

kisslorand commented 11 months ago

It's something I have to check on the original firmware. Will come back with the results, I am sure it can be solved.

discip commented 11 months ago

I remember having a similar issue with the original firmware.

If I found the right spot than this should be the fix:

https://github.com/digant73/BIGTREETECH-TouchScreenFirmware/commit/82d754bee8fc524d3b4db8579fd540b6b410ede7

kisslorand commented 11 months ago

The link above is about the file extension, not about thumbnails.

discip commented 11 months ago

Yes, but it seems to be related to this issue somehow as discussed here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/2300#issuecomment-1003675156

kisslorand commented 11 months ago

OK. I will look into it.

kisslorand commented 11 months ago

The issue has been found, working on a fix for it.

kisslorand commented 11 months ago

It has been fixed, repository is updated with the fixes. Thank you!

discip commented 11 months ago

... Thank you!

Clearly I'm the one having to thank you! 😃👍

Will test as soon as I'm home again.

discip commented 11 months ago

Unfortunately there was a print running up until now, which on the other hand proved the hesitation problem to be solved! 👍🏻 🎉

After flashing the latest firmware the previously described ISSUES are GONE!

Thank you so much!

discip commented 11 months ago

May I ask if it makes sense to improve this browsing behavior even further without affecting performance?

I was thinking about storing the 'thumbnails-pages' after loading so that they don't have to be loaded individually each time the files are browsed.

kisslorand commented 11 months ago

There is no place to store them, they are loaded directly into the RAM of the display driver as the file is accessed.

discip commented 11 months ago

Alright. Thanks for the clarification! 👍