search

kissmetrics / KISSmetrics-iOS-SDK

iOS SDK for KISSmetrics
http://support.kissmetrics.com/doc/apis-integrations-and-importing-data/#29
6 stars 18 forks source link

Tweak tests, add new documentation #24

Closed peteoleary closed 7 years ago

peteoleary commented 7 years ago

None

On Thu, Feb 23, 2017 at 11:09 AM, Andrew Hanna notifications@github.com wrote:

@percyhanna commented on this pull request.

There's some shared commits between this and #23 https://github.com/kissmetrics/KISSmetrics-iOS-SDK/pull/23. Any significance in the order of how they're merged?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kissmetrics/KISSmetrics-iOS-SDK/pull/24#pullrequestreview-23560343, or mute the thread https://github.com/notifications/unsubscribe-auth/AEEm4HBx3AOVTdCBqmAk0D8TcU_E2A0wks5rfdl6gaJpZM4MH_uB .

peteoleary commented 7 years ago

Github did something weird for me. I had a separate branch in my fork and went to merge it back into my fork's master via a pull request which is what I normally do. Github created the pull request in the parent repo instead which is not what I expected.

On Thu, Feb 23, 2017 at 11:50 AM, Peter O'Leary pete@timelight.com wrote:

None

On Thu, Feb 23, 2017 at 11:09 AM, Andrew Hanna notifications@github.com wrote:

@percyhanna commented on this pull request.

There's some shared commits between this and #23 https://github.com/kissmetrics/KISSmetrics-iOS-SDK/pull/23. Any significance in the order of how they're merged?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kissmetrics/KISSmetrics-iOS-SDK/pull/24#pullrequestreview-23560343, or mute the thread https://github.com/notifications/unsubscribe-auth/AEEm4HBx3AOVTdCBqmAk0D8TcU_E2A0wks5rfdl6gaJpZM4MH_uB .