search

kisstkondoros / codemetrics

VSCode extension which shows the complexity information for TypeScript class members
Other
404 stars 20 forks source link

Update the activationEvents property #71

Closed igorskyflyer closed 5 years ago

igorskyflyer commented 5 years ago

// An extended description

Hello, fellow developer(s), let me first introduce myself.

My name is Igor and I am like yourself a developer that uses Visual Studio Code as my main code editor. One of the main reasons why developers around the world love Visual Studio Code is because of its speed, right?

The developers have done a wonderful work with the editor itself but we - the users and active developers / contributors - should speed it up even more. I noticed that a lot of extensions - which are really helpful - don't use the proper "activationEvents" property which in turn slows down Visual Studio Code load time.

That is why I wanted to start an initiative that will do exactly that. I myself (and maybe other developers too in the future) will examine the Visual Studio Code extensions that I am / we are actively using, like yours, and either improve their performance or their activation events.

I am proposing my changes on your Github as a pull request and you are more than welcome to test / debug the changed code and integrate it in your codebase if you find the changes suitable.

By integrating the proposed changes the extension won't be loaded when the editor starts but only when a file with one the supported languages has been opened or the extension's command(s) has / have been executed.

Thank you for reading, best regards, Igor.

kisstkondoros commented 5 years ago

I'm going to merge the PR soon. There is one minor thing which I have to adjust as the vue support would break otherwise.

kisstkondoros commented 5 years ago

Version 1.22.1 should be available soon in the marketplace. Thanks for the contribution!

igorskyflyer commented 5 years ago

You're welcome and thank you for a great extension! :)