Question: Why does method reference add complexity to a method?

[vivekmore]

    private List<String> myMethod1(String s1, String s2) {
        List<String> list = new ArrayList<>();
        if (s1 != null) list.add(s1.toLowerCase());
        if (s2 != null) list.add(s2.toLowerCase());
        return list;
    }

    private List<String> myMethod2(String s1, String s2) {
        List<String> list = new ArrayList<>();
        Optional.ofNullable(s1).map(String::toLowerCase).ifPresent(list::add);
        Optional.ofNullable(s2).map(String::toLowerCase).ifPresent(list::add);
        return list;
    }

these methods should not have same complexity score

[kisstkondoros]

Thanks for raising an issue, in the wrong repo though :sweat_smile:

My explanation for this (wrong behavior) would be

1. 2 if clauses, 2 boolean conditions, no method declarations +4
2. 4 method references +4

Whether this is good or bad is up to interpretation (and configuration), you can fine tune it in the settings.

If you have a more concrete recommendation about this, please file a new issue in the correct repo (https://github.com/kisstkondoros/codemetrics-idea)