search

kisstkondoros / gutter-preview

Other
158 stars 37 forks source link

Updated the python regex to account for lines with multiple strings #12

Closed jakex10sen closed 7 years ago

jakex10sen commented 7 years ago

Overview

While using the new feature I noticed a bug where lines that had multiple strings wouldn't display images so I tuned the regex to fix the issue. The line below is an example of a case that would fail to produce an image.

Example

Pattern("This is the description", 95, "image.png")
kisstkondoros commented 7 years ago

I see some problem with e.g.

Pattern('This is the description', 95, "image.png")
Pattern("Not working.why", 95, "image.png")

but by merging your changes it's still got a lot better ^^.

Thank you!

P.S.: vscode-gutter-preview@0.11.2 published to the market

jakex10sen commented 7 years ago

I have started working on resolving this issue.