search

kisstkondoros / gutter-preview

Other
158 stars 37 forks source link

vscode 1.28.2 - windows 10 october update #29

Closed GrosBourrin closed 6 years ago

GrosBourrin commented 6 years ago

works now but with only one tab at a time....in the release notes it says for vscode 1.29 but only 1.28.2 is effective... you mean 1.29 insider version i presume ...

kisstkondoros commented 6 years ago

1.29 was a typo in the readme, I've fixed it now thanks for pointing it out.

About

works now but with only one tab at a time

What does this exactly means? You are mentioning this several times now, but I don't know how could that be... Here is an image showing https://github.com/zachleat/browser-logo-icon-set opened in vscode having two tabs opened, edited and scrolled up and down... screenshot 2018-10-20 16 36 35

GrosBourrin commented 6 years ago

1 file opened (working) : 2018-10-21_00h42_07

2 files opened (not working) : 2018-10-21_00h41_13

edit : strangely if i put tabs side by side, it works for each tabs ! about tabs i mean files..

2018-10-21_00h52_29 2018-10-21_00h52_37

kisstkondoros commented 6 years ago

Ok so it seems the problem had nothing to do with how many tabs or files are opened at once, but to an unhandled error when fetching images... In the screenshots I've noticed the protocol "chrome://" which eventually caused the trouble. (It was obvioulsy a mistake from my side)

I hope version v0.16.2 will finally put an end to this bug.

P.S. Please, please, if you ever report a bug to anyone: first create a minimal reproducible example. With that we could have identified the problem much faster, and could got the bug fixed in a day or two...

GrosBourrin commented 6 years ago

works great now ! you're the boss ! about your P.S. : that's ok ! that's why i did screenshots ! i have finally noticed how to do that correctly ! thanks for your patience

kisstkondoros commented 6 years ago

:relaxed: