search

kisstkondoros / gutter-preview

Other
158 stars 37 forks source link

Maybe preview like Brackets does? #4

Closed fluxxus closed 7 years ago

fluxxus commented 7 years ago

Have you seen the way Brackets handles image previews? When you hover over the image path(both HTML and CSS) a nice popup appears with image in original dimensions, if it is too big, then it is rezised.

Gutter preview is really nice, but apart from icons, other images are really small, basically I can't see the image previewed, all blurred and small.

If it is any help, here is the repo for that extension(later it was added to Brackets core) https://github.com/gruehle/HoverPreview

kisstkondoros commented 7 years ago

Hi,

I just had a deeper look into this. A similar functionality already exists, but due to the current VSCode API limitations it only supports a very limited markdown syntax to provide the hover content. Moreover the markdown processor they use ( marked ) does not supports image resizing without some additional configuration (which I can not do from an extension).

So I'm afraid I can't do anything about it currently.

kisstkondoros commented 7 years ago

Feature request issued for this in the vscode repo: https://github.com/Microsoft/vscode/issues/14803

kisstkondoros commented 7 years ago

Just published v0.7.2 to the market. Using that and vscode version 1.8 ( insider preview ) and above should provide a better experience.

fluxxus commented 7 years ago

Great, I'll give it a try !

fluxxus commented 7 years ago

Excellent work !

Is it possible to have an option to remove the initial left-sided gutter preview, and only have the popup available?

Thanks

p.s. and maybe change name extension to Image Preview or similar, cause it is definitely not just gutter preview now.

kisstkondoros commented 7 years ago

Version 0.8.1 is in the market! By using the following setting, the preview on the gutter can be disabled:

"gutterpreview.showimagepreviewongutter": false

(reopening the text editors might be necessary to take effect)

fluxxus commented 7 years ago

Super nice! Thanks for the quick implementation.

The way it is functioning now, I believe that it is much better way to preview images, than just having gutter side preview.