kit-cel / gr-radar

GNU Radio Radar Toolbox
GNU General Public License v3.0
237 stars 83 forks source link

Making the build dependent on UHD is a bad idea #48

Open NeuroForLunch opened 3 years ago

NeuroForLunch commented 3 years ago

It should check whether or not its installed like it does with doxygen and ignore it if it's not there. I'm using different hardware and UHD has a dependency of GNURadio 3.8.1 whereas I'm using a higher version so it conflicts on the install.

Here's the results from apt-get install python3-UHD:

The following NEW packages will be installed:
  curl fonts-lyx freeglut3 gnuradio gnuradio-dev
  libcanberra-gtk-module libcanberra-gtk0 libcanberra-gtk3-module
  libcppunit-1.15-0 libcppunit-dev libgnuradio-analog3.8.1
  libgnuradio-audio3.8.1 libgnuradio-blocks3.8.1
  libgnuradio-channels3.8.1 libgnuradio-digital3.8.1
  libgnuradio-dtv3.8.1 libgnuradio-fec3.8.1 libgnuradio-fft3.8.1
  libgnuradio-filter3.8.1 libgnuradio-pmt3.8.1
  libgnuradio-qtgui3.8.1 libgnuradio-runtime3.8.1
  libgnuradio-trellis3.8.1 libgnuradio-uhd3.8.1
  libgnuradio-video-sdl3.8.1 libgnuradio-vocoder3.8.1
  libgnuradio-wavelet3.8.1 libgnuradio-zeromq3.8.1
  libpython2-stdlib libpython2.7-minimal libpython2.7-stdlib
  librtlsdr0 libvolk2-bin libvolk2-dev libvolk2.2
  python-matplotlib-data python2 python2-minimal python2.7
  python2.7-minimal python3-bs4 python3-cycler python3-kiwisolver
  python3-lxml python3-mako python3-matplotlib python3-networkx
  python3-opengl python3-pyqtgraph python3-soupsieve python3-tk
  python3-uhd rtl-sdr ttf-bitstream-vera uhd-host
0 upgraded, 55 newly installed, 0 to remove and 0 not upgraded.
Need to get 151 MB of archives.
After this operation, 542 MB of additional disk space will be used.
Do you want to continue? [Y/n]

The UHD packages make no sense in terms of their dependencies - like why is Python2 required on a package called python3-UHD?

Conclusion: just make UHD optional so other products can be used instead.