search

kit-cel / gr-radar

GNU Radio Radar Toolbox
GNU General Public License v3.0
237 stars 83 forks source link

Changes to be committed: #64

Open hellocaoziyi opened 4 months ago

hellocaoziyi commented 4 months ago

modified the file structure and cmake files to migrate to version 3.10. modified: CMakeLists.txt modified: README.md modified: cmake/Modules/gnuradio-radarConfig.cmake modified: lib/CMakeLists.txt modified: lib/scatter_plot.h modified: python/radar/CMakeLists.txt modified: python/radar/init.py modified: python/radar/bindings/CMakeLists.txt new file: python/radar/bindings/bind_oot_file.py modified: python/radar/bindings/python_bindings.cc

hellocaoziyi commented 4 months ago

@noc0lour @ryanvolz Can you help me merge? Or are there any changes that need to be made?

ryanvolz commented 4 months ago

I don't have merge powers here, so someone who does will have to come along. I don't think I see anything in here that I would object to, but it might help to break this up into a few smaller PRs for review purposes.

One necessary change would be to remove the __pycache__ directories and corresponding .pyc files from the commit.

It's also unclear to me from the GitHub changed files summary whether the header files are being moved (as desired) or a duplicate set is being added, but I suspect the latter.

hellocaoziyi commented 4 months ago

Thank you, @ryanvolz. I've mode the modifications as Ryan's suggestions. Following the example of GNU Radio gr-modtool. I've moved the header files form the original location at include/radar to include/gnuradio/radar