kit-clj / kit

Lightweight, modular framework for scalable web development in Clojure
https://kit-clj.github.io/
MIT License
463 stars 43 forks source link

Make it easy to discover kit-hato #104

Closed vemv closed 5 months ago

vemv commented 1 year ago

Hey there,

AFAIK there's no kit-hato module, and https://kit-clj.github.io/docs/kit-hato.html doesn't point to a set of Maven coordinates. I had to find https://clojars.org/io.github.kit-clj/kit-hato independently.

Not a big deal but I figured an issue could help.

Cheers - V

gerdint commented 11 months ago

A module would be nice, but failing that I guess this is the reason why the Maven coords are listed quite prominently on the Kit GitHub frontpage

yogthos commented 11 months ago

I've linked to the version under the useful libraries section here https://kit-clj.github.io/docs/useful_libraries.html

A module for hato would be easy to add, would just need to inject a component and a dependency. If anybody wants to take a look, I'd be happy to take a PR for that. Would just need to add it here https://github.com/kit-clj/modules

jmarijano commented 5 months ago

Hi, I saw that this issue had the "good first issue" label on it. I forked the modules repository and wanted to check if I'm on the right track to add the hato module. Link to the diff: Add hato module

yogthos commented 5 months ago

Hi, thanks for taking interest and the diff looks about right to me.

jmarijano commented 5 months ago

Thanks for looking at it. I will create a pull request.