kit-clj / kit

Lightweight, modular framework for scalable web development in Clojure
https://kit-clj.github.io/
MIT License
476 stars 44 forks source link

creating template with deps-new does not create folders properly in windows #113

Closed muthuishere closed 1 year ago

muthuishere commented 1 year ago

I used the below command to create a template. neil new io.github.kit-clj/kit deemwar/helloweb

The expectation is to create all source code files under folders deemwar/helloweb

It works fine in mac , But in windows ,folders are not created. neil , babashka ,clojure installed via scoop in windows

Mac Screen shot

image

Windows Screenshot

image
yogthos commented 1 year ago

Unfortunately, I don't have windows to test locally. It sounds like there's a path issue, could be that there's a hardcoded / separator somewhere that should be File/separator instead.

muthuishere commented 1 year ago

It did worked with clj-new after fixing the powershell quote issue

The below does not work

 clojure -Tcljnew create :template io.github.kit-clj :name yourname/apps

The below works

 clojure -Tcljnew create :template io.github.kit-clj :name """yourname/apps"""

but for deps-new , I could not know , how to pass these parameters?

yogthos commented 1 year ago

Ah I see, I guess the issue is with powershell escaping then?

muthuishere commented 1 year ago

Yeah , the issue is resolved in clj-new , now i need your help , how to fix with deps-new

I tried adding quote with neil new io.github.kit-clj/kit deemwar/helloweb. , still it does not help

yogthos commented 1 year ago

Unfortunately, I'm not entirely sure what to do there either. Could you try using bash on windows to see if it'll work that way?

muthuishere commented 1 year ago

I tried using git bash , But the issue still exists. I have a question , How did neil gets translated to deps-new ,

neil new io.github.kit-clj/kit deemwar/helloweb

what would be the translated deps-new cli version any idea?

yogthos commented 1 year ago

Good question, might be worth opening an issue for neil

muthuishere commented 1 year ago

Also clj-new works well ,Only issue is with deps-new , can you point me which one is executed for clj-new and which one for deps-new?

yogthos commented 1 year ago

Here's the PR for deps-new https://github.com/kit-clj/kit/pull/72

muthuishere commented 1 year ago

I could able to fix it , Its File Seperator issue as you said initially , I have updated the tests as well , so it could be platform independent. Can i raise a PR?

muthuishere commented 1 year ago

raised a fix , explained here what changes has been updated https://www.twitch.tv/videos/1919389924

yogthos commented 1 year ago

Thanks, and the change looks good.

yogthos commented 1 year ago

And just pushed out a template update to Clojars, if everything looks good on your end I think we can close. Thanks again for investigating.

muthuishere commented 1 year ago

Thanks a lot , It works now in windows