search

kit-clj / kit

Lightweight, modular framework for scalable web development in Clojure
https://kit-clj.github.io/
MIT License
489 stars 44 forks source link

Test fixture does not reload system state when running tests interactively #148

Open positron opened 2 months ago

positron commented 2 months ago

I expected this workflow to work:

  1. Run a test in my text editor (aka using REPL) using the fixture kit-clj generated (use-fixtures :once (<my-ns>.test-utils/system-fixture)) - it fails
  2. Change some api route config or code
  3. Re-run the test and see behavior changed

Especially surprising to me because I was changing the code in the :handler but even that didn't get updated, because the built reitit API stuff was referencing the old version of that fn. :)

I don't think this should be intended behavior. IMHO using a test fixture implies that it is coming up with repeatable, fresh new state every time the fixture is called. To underscore that difference, with this setup there is no difference between :each or :once.

Anyway, if this is not intended behavior, it is because of this code:

https://github.com/kit-clj/kit/blob/master/libs/deps-template/resources/io/github/kit_clj/kit/test/clj/test_utils.clj#L12-L16

I changed mine to always call core/start-app.

vollcheck commented 2 months ago

Do you, after step 2nd, run (reset) from the REPL?

positron commented 2 months ago

No. That would probably work too.

If that's the intended workflow feel free to close. It's just not the workflow I'm used to coming from some older clojure projects based on stuartsierra/component.

vollcheck commented 2 months ago

The thing is that reloading whole project on save might result in REPL lags especially in bigger applications hence proposed approach with reloaded workflow.

Feel free to modify project settings to your need though.