Fix holiday check for school holidays

kit-sdq / TimeSheetGenerator

TimeSheetGenerator is an application that checks and builds time sheet documents.

MIT License

23 stars 6 forks source link

Fix holiday check for school holidays #121

Closed klegul closed 1 year ago

klegul commented 1 year ago

Currently the API feiertag-api.de is used and all entries are interpreted as work holidays. Currently two days are only school holidays and not work holidays. These dates has a special note attached in JSON. This pull request checks for this note and ignores the day.

It is not really future proof because this check fails, when the note is changed, but I don't know any better way.

larsk21 commented 1 year ago

How about checking for an occurence of the word "schulfrei"?

dfuchss commented 1 year ago

I've added a formatted and updated to Java 17 / JUnit5. Therefore, this PR needs small adaptions :)