Closed Luro02 closed 10 months ago
Thx for the PR!
Could you adapt the PR that it is backwards compatible. Especially, for the eclipse plugin, the plugin should show the assessed tasks in the backlog and not all.
Could you adapt the PR that it is backwards compatible.
How should I do this? Even if I change the boolean
to true
, the PR will still be backwards incompatible, because I changed the method in the interface.
You create a new method List<Submission> getSubmissions(Exercise exercise, int correctionRound, boolean filterAssessedByTutor)
. The old method (without bool) should behave same as before. Afterwards, we can use the new interface in the stats tool
@dfuchss fixed it
Ok .. I'll test it. Credentials are locked :)
CI is green :)
Artemis allows non-instructors to fetch all submissions and not only the ones assessed by the tutor (with this change tutors will be able to use https://github.com/kit-sdq/programming-lecture-artemis-score-stats).
The original python API had this method signature for the endpoint:
which allowed the caller to specify the options for the endpoint.
I tried to replicate the same behaviour for the Java API. The Javadoc of
getSubmissions
does not gurantee that the returned submissions are only those assessed by a tutor:Therefore I changed the default to
false
, so it really returns "all submissions".