search

kit-sdq / artemis4j

REST Client for the Artemis Project
Eclipse Public License 2.0
5 stars 6 forks source link

Do some changes for `programming-lecture-artemis-score-stats` #92

Closed Luro02 closed 2 months ago

dfuchss commented 2 months ago

Please add a short description what has changed why :) Otherwise, it's hard to determine whether a change (besides adding getters) makes sense :)

Luro02 commented 2 months ago

Please add a short description what has changed why :) Otherwise, it's hard to determine whether a change (besides adding getters) makes sense :)

The diff is quite small, so I deemed it unnecessary to add a description. What changes should I describe? The getters are obvious and the only other change is the openAssessment method, for which I added Javadoc.

The Assessment is the abstraction over the ResultDTO of a submission. To see how a student has been graded, I need to open that assessment.

What might be mentioned: save/submit might not work, but if i remember correctly, Artemis lets you steal the assessment of another tutor.

Other than that, I adjusted the code to fetch feedbacks if they are missing and made the bug fix to the get relevant result, like we discussed on element.

dfuchss commented 2 months ago

Could you open the PR in the repository itself? With your fork the CI cannot access the Secrets needed for the Test environment :)