search

kit-sdq / artemis4j

REST Client for the Artemis Project
Eclipse Public License 2.0
5 stars 6 forks source link

Update Artemis4J to expose necessary data for `programming-lecture-artemis-score-stats` #96

Closed Luro02 closed 2 months ago

Luro02 commented 2 months ago

This uses a branch on the repo to make the PR, https://github.com/kit-sdq/artemis4j/pull/92

Luro02 commented 2 months ago

I will address the open review/failing tests soon and might add some tests as well

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dfuchss commented 2 months ago

@Luro02 please have a look at sonarlint and check which issues can be resolved :)

Luro02 commented 2 months ago

@Luro02 please have a look at sonarlint and check which issues can be resolved :)

I am running SonarLint locally, so I know about most of the mentioned "issues". Note that I explicitly wrote if (feedback.hasLongFeebackText()) { instead of if (Boolean.TRUE.equals(feedback.hasLongFeedbackText())) {, so that it crashes when hasLongFeedbackText returns null (so we know that the API changed/some endpoint does weird things)...

Spotless takes care of redundant imports, which has been applied in my last commit. For some reason the SonarLint thing is living in the past and not using the latest commit (even though it made a new comment after I made that commit)