pool: All pool types now panic if configured after use.
pool: ContextPool and ResultContextPool now always cancels its context when Wait() returns.
pool: ContextPool and ResultContextPool now cancels its context when a task panics.
panics: panics.RecoveredPanic and panics.NewRecoveredPanic(...) have been renamed panics.Recovered and panics.NewRecovered(...) respectively.
panics: panics.Recovered no longer implements error directly, which would previously have unintended side effects - instead, it can be converted into an error implementation explicitly with (*Recovered).AsError().
panics: Added a package-level panics.Try(...) for recovering from panics from a single function.
multierrors: For pools that return multiple errors:
Some of the changes listed above are breaking changes - this package is currently pre-1.0, and there are likely to be other breaking changes before a 1.0 release as we stabilize the APIs and tweak defaults. Please open an issue if you have questions, concerns, or requests that you'd like addressed before the 1.0 release. Currently, a 1.0 is targeted for March 2023.
Commits
7b8c8f2 Merge pull request #97 from sourcegraph/multierror-internal
You can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
Bumps github.com/sourcegraph/conc from 0.2.0 to 0.3.0.
Release notes
Sourced from github.com/sourcegraph/conc's releases.
Commits
7b8c8f2
Merge pull request #97 from sourcegraph/multierror-internal4d3065d
multierror: move to internal packagee2914e5
Merge pull request #96 from sourcegraph/panics-naming-simplification279d23c
panics: reduce naming stutter in panics.RecoveredPanic771c4b0
Merge pull request #92 from sourcegraph/context-pool-panice8fb035
pool: add WithCancelOnError and panic test case for ResultContextPoolf978b8f
pool: use simple defer recover14c5081
revert test change3d93654
fix racy test1df97ec
replace Sourcegraph error lib for smaller dependencyYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)