kitadai31 / revanced-manager-android5-7

ReVanced Manager for Android 5.0-7.1
GNU General Public License v3.0
108 stars 8 forks source link

bug: Modifying options.toml refuse to work #16

Closed userunknown358 closed 4 months ago

userunknown358 commented 4 months ago

Bug description

Attempting to patch 17.34.36 via Revanced Manager that is designed for Android 5-7

Version of ReVanced Manager and version & name of application you tried to patch

Latest version of the patcher YouTube app downloaded from Apkmirror

Installation type

None

Device logs

{"com.google.android.youtube":["check-android-version","custom-branding-icon-afn-red","custom-branding-name","custom-seekbar-color","custom-video-speed","default-video-quality","default-video-speed","disable-haptic-feedback","disable-update-screen","enable-external-browser","enable-minimized-playback","enable-old-quality-layout","enable-open-links-directly","enable-seekbar-tapping","enable-tablet-miniplayer","enable-wide-searchbar","force-vp9-codec","header-switch","hide-auto-captions","hide-auto-player-popup-panels","hide-autoplay-button","hide-button-container","hide-cast-button","hide-channel-watermark","hide-comment-component","hide-create-button","hide-crowdfunding-box","hide-email-address","hide-endscreen-cards","hide-endscreen-overlay","hide-filmstrip-overlay","hide-firsttime-background-notification","hide-flyout-panel","hide-fullscreen-panels","hide-general-ads","hide-info-cards","hide-live-chat-button","hide-mix-playlists","hide-next-prev-button","hide-player-captions-button","hide-player-overlay-filter","hide-shorts-button","hide-shorts-component","hide-snackbar","hide-startup-shorts-player","hide-suggested-actions","hide-time-and-seekbar","hide-tooltip-content","hide-video-ads","layout-switch","microg-support","optimize-resource","overlay-buttons","patch-options","return-youtube-dislike","sponsorblock","spoof-app-version","spoof-client","swipe-controls","switch-create-notification","theme","translations","remove-player-button-background"]}

Patcher logs

- Device Info
ReVanced Manager: 1.17.4
Build: release
Model: WDY-LX1
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.google.android.youtube v17.34.36
Patches version: v2.160.10
Patches: check-android-version, custom-branding-icon-afn-red, custom-branding-name, custom-seekbar-color, custom-video-speed, default-video-quality, default-video-speed, disable-haptic-feedback, disable-update-screen, enable-external-browser, enable-minimized-playback, enable-old-quality-layout, enable-open-links-directly, enable-seekbar-tapping, enable-tablet-miniplayer, enable-wide-searchbar, force-vp9-codec, header-switch, hide-auto-captions, hide-auto-player-popup-panels, hide-autoplay-button, hide-button-container, hide-cast-button, hide-channel-watermark, hide-comment-component, hide-create-button, hide-crowdfunding-box, hide-email-address, hide-endscreen-cards, hide-endscreen-overlay, hide-filmstrip-overlay, hide-firsttime-background-notification, hide-flyout-panel, hide-fullscreen-panels, hide-general-ads, hide-info-cards, hide-live-chat-button, hide-mix-playlists, hide-next-prev-button, hide-player-captions-button, hide-player-overlay-filter, hide-shorts-button, hide-shorts-component, hide-snackbar, hide-startup-shorts-player, hide-suggested-actions, hide-time-and-seekbar, hide-tooltip-content, hide-video-ads, layout-switch, microg-support, optimize-resource, overlay-buttons, patch-options [Application Name of YouTube: YouTube, Package Name of YouTube: rev.old.android.youtube, Custom Speed Values: 0.25, 0.5, 0.75, 1.0, 1.25, 1.5, 1.75, 2.0, 2.25, 2.5, 3.0, 5.0, Overlay button icon selection: old, Background color for the dark theme: @android:color/grey], remove-player-button-background, return-youtube-dislike, sponsorblock, spoof-app-version, spoof-client, swipe-controls, switch-create-notification, theme, translations

- Settings
Allow changing patch selection: true
Version compatibility check: false
Show universal patches: true
Remove unused library: false
Patches source: kitadai31/revanced-patches-android6-7
Integration source: kitadai31/revanced-integrations

- Logs
Copying APK
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing resource cache directory
Decoding resources
Executing patches
check-android-version succeeded
custom-branding-icon-afn-red succeeded
custom-branding-name succeeded
custom-seekbar-color succeeded
custom-video-speed succeeded
default-video-quality succeeded
default-video-speed succeeded
disable-haptic-feedback succeeded
disable-update-screen succeeded
enable-external-browser succeeded
enable-minimized-playback succeeded
enable-old-quality-layout succeeded
enable-open-links-directly succeeded
enable-seekbar-tapping succeeded
enable-tablet-miniplayer succeeded
enable-wide-searchbar succeeded
force-vp9-codec succeeded
header-switch succeeded
hide-auto-captions succeeded
hide-auto-player-popup-panels succeeded
hide-autoplay-button succeeded
hide-button-container succeeded
hide-cast-button succeeded
hide-channel-watermark succeeded
hide-comment-component succeeded
hide-create-button succeeded
hide-crowdfunding-box succeeded
hide-email-address succeeded
hide-endscreen-cards succeeded
hide-endscreen-overlay succeeded
hide-filmstrip-overlay succeeded
hide-firsttime-background-notification succeeded
hide-flyout-panel succeeded
hide-fullscreen-panels succeeded
hide-general-ads succeeded
hide-info-cards succeeded
hide-live-chat-button succeeded
hide-mix-playlists succeeded
hide-next-prev-button succeeded
hide-player-captions-button succeeded
hide-player-overlay-filter succeeded
hide-shorts-button succeeded
hide-shorts-component succeeded
hide-snackbar succeeded
hide-startup-shorts-player succeeded
hide-suggested-actions succeeded
hide-time-and-seekbar succeeded
hide-tooltip-content succeeded
hide-video-ads succeeded
layout-switch succeeded
microg-support succeeded
optimize-resource succeeded
overlay-buttons succeeded
patch-options succeeded
remove-player-button-background succeeded
return-youtube-dislike succeeded
sponsorblock succeeded
spoof-app-version succeeded
spoof-client succeeded
swipe-controls succeeded
switch-create-notification succeeded
theme succeeded
translations succeeded
Compiling modified dex files
Compiling modified resources
An error occurred:
s0.b: C0.a: could not exec (exit code = 1): [/data/app/~~eZC1EAnJFNgr1OWnwKEkwA==/app.kitadai31.manager.flutter-DOsPEyrG_sVfk6KkexxLpQ==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 23, --target-sdk-version, 33, --version-code, 1531307456, --version-name, 17.34.36, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /data/user/0/app.kitadai31.manager.flutter/cache/APKTOOL8713122900254318256.tmp, -0, arsc, -I, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/1.apk, --manifest, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/AndroidManifest.xml, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/build/resources.zip]
    at q0.a.f(SourceFile:1)
    at q0.a.d(SourceFile:107)
    at app.revanced.patcher.data.ResourceContext.get(SourceFile:1)
    at app.revanced.patcher.Patcher.get(SourceFile:1)
    at app.revanced.manager.flutter.MainActivity.n0(SourceFile:1)
    at app.revanced.manager.flutter.MainActivity.V(SourceFile:1)
    at k0.d.run(SourceFile:1)
    at java.lang.Thread.run(Thread.java:1012)
Caused by: C0.a: could not exec (exit code = 1): [/data/app/~~eZC1EAnJFNgr1OWnwKEkwA==/app.kitadai31.manager.flutter-DOsPEyrG_sVfk6KkexxLpQ==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 23, --target-sdk-version, 33, --version-code, 1531307456, --version-name, 17.34.36, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /data/user/0/app.kitadai31.manager.flutter/cache/APKTOOL8713122900254318256.tmp, -0, arsc, -I, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/1.apk, --manifest, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/AndroidManifest.xml, /data/user/0/app.kitadai31.manager.flutter/cache/patcher/tmp-KFMIYU/cache/build/resources.zip]
    at E0.h.b(SourceFile:76)
    ... 8 more

Acknowledgements

kitadai31 commented 4 months ago

typo in options @android:color/grey -> @android:color/gray

userunknown358 commented 4 months ago

Does the overlay buttons (new/old) work???

kitadai31 commented 4 months ago

idk try it

userunknown358 commented 4 months ago

I tried it by switching to old, it doesn't work.

userunknown358 commented 4 months ago

Have you tried the background colors?

kitadai31 commented 4 months ago

If you want the old overlay icon, please use ReVanced CLI (or Revancify) I can't fix

I don't know about background colors gray will works