kitadai31 / revanced-patches-android6-7

YouTube ReVanced for Android 6.0-7.1
GNU General Public License v3.0
195 stars 15 forks source link

bug: Comment section container is rounded #84

Closed userunknown358 closed 3 months ago

userunknown358 commented 3 months ago

Type

Other

Bug description

I watch a video and the comment preview container makes zero sense

Steps to reproduce

Step 1. Spoof version to 17.33.42 Step 2. Reload the app Step 3. Find a video to watch

Relevant log output

No response

Screenshots or videos

Screenshot_20240814_133711

Solution

Adding an option to change the comment container

Additional context

No response

Device Environment

Android 7.1

Acknowledgements

kitadai31 commented 3 months ago

Server-side layout, cannot control by patch

jpa102 commented 3 months ago

they made it fully rounded now (i modified the non functional youtube vanced for this)

Screenshot_20240819_215846.png

this is what it used to look like, am i right?

Screenshot_20240405_051005.png

Screenshot_20240401_094616.png

version 17.39.35 had this rounded design (with l the most replayed feature), it seems that they modified the other versions below it as well to get rid of the old non-rounded design completely

that's just my guess though, we might not know if youtube will pull the plug on versions 17.xx.xx and 18.xx.xx so it renders these client versions unusable (17.34.36 spoofed with versions 19.xx.xx makes it crash or have tons of glitches)

userunknown358 commented 3 months ago

they made it fully rounded now (i modified the non functional youtube vanced for this)

Screenshot_20240819_215846.png

this is what it used to look like, am i right?

Screenshot_20240405_051005.png

Screenshot_20240401_094616.png

version 17.39.35 had this rounded design (with l the most replayed feature), it seems that they modified the other versions below it as well to get rid of the old non-rounded design completely

that's just my guess though, we might not know if youtube will pull the plug on versions 17.xx.xx and 18.xx.xx so it renders these client versions unusable (17.34.36 spoofed with versions 19.xx.xx makes it crash or have tons of glitches)

There needs to be a fix ASAP

jpa102 commented 3 months ago

There needs to be a fix ASAP

i don't know, but you can probably ask the internal youtube devs for this as they have full control on what kind of ui to display to youtube clients from their servers

maybe try asking to the official revanced repository (highly doubt they will acknowledge your request)

as kitadai31 said, they have no control to reverse this change (even better, read the "skill issue" part at the readme.md)

on the website / desktop version though, it's just simple css edits (remove the background-color or similar and adjust the padding or margin)

since i have no experience on modifying mobile apps, i have no idea on how to do this

kitadai31 commented 3 months ago

At one point, 17.34.36 had a incomplete UI like this.

243095395-01cedcf7-549b-469f-a82c-07b2e2d92d26

Layouts of YouTube app are constructed by Litho component, which is delivered by server-side It's like a html + css of native apps

userunknown358 commented 3 months ago

At one point, 17.34.36 had a incomplete UI like this.

243095395-01cedcf7-549b-469f-a82c-07b2e2d92d26

Layouts of YouTube app are constructed by Litho component, which is delivered by server-side It's like a html + css of native apps

I remember having that UI last year

userunknown358 commented 3 months ago

At one point, 17.34.36 had a incomplete UI like this.

243095395-01cedcf7-549b-469f-a82c-07b2e2d92d26

Layouts of YouTube app are constructed by Litho component, which is delivered by server-side It's like a html + css of native apps

If only it could be changed by changing the api but sadly, it's very difficult

jpa102 commented 3 months ago

It's like a html + css of native apps

ah, i see

At one point, 17.34.36 had a incomplete UI like this.

so it's like the early days of youtube testing the rounded design elements?

don't mind my screenshot, this is my attempt at recreating the non-rounded ui that i love the most in "website" form

image

If only it could be changed by changing the api but sadly, it's very difficult

with youtube being closed source as usual, it adds up to the difficulty

userunknown358 commented 3 months ago

It's like a html + css of native apps

ah, i see

At one point, 17.34.36 had a incomplete UI like this.

so it's like the early days of youtube testing the rounded design elements?

don't mind my screenshot, this is my attempt at recreating the non-rounded ui that i love the most in "website" form

image

If only it could be changed by changing the api but sadly, it's very difficult

with youtube being closed source as usual, it adds up to the difficulty

Would you please provide a download link once it's completed and also, there is an old YouTube mobile userscript that restores 40% of the old layout.

jpa102 commented 3 months ago

Would you please provide a download link

it's more of my personal project for fun, sorry about that

there is an old YouTube mobile userscript

i'm aware of similar userscripts, but it's just that i find the mobile site version of yt very difficult to deal with and get used to

even if i wanted the old mobile ui back, i will not use their hot dog water mobile site version (unless i have no time using the desktop version on my phone, i even indirectly use the mobile site using yt-dlp)

i can give reasons why not, but let's keep this discussion leaning to your original issue

userunknown358 commented 3 months ago

it's more of my personal project for fun, sorry about that

Not to mention it's broken but oh well. We have ytm15 (Which faithfully restores the old YouTube Mobile layout although 2017 isn't that accurate)

jpa102 commented 3 months ago

ytm15

yeah, i just discovered that site. it's decent in my opinion

i don't know if it's just me, but it doesn't load replies

still cool seeing it use the return youtube dislike api though

userunknown358 commented 3 months ago

ytm15

yeah, i just discovered that site. it's decent in my opinion

i don't know if it's just me, but it doesn't load replies

still cool seeing it use the return youtube dislike api though

It's in development at this time

jpa102 commented 3 months ago

i see, that's nice seeing others run their own youtube frontends

i have my own project, but i'm not trying to compete with others though

userunknown358 commented 2 months ago

i have my own project, but i'm not trying to compete with others though

Nice