kitagry / asyncomplete-tabnine.vim

Experimental plugin for asyncomplete.vim and tabnine
13 stars 4 forks source link

can setting tabnine's min and max value #1

Closed get-me-power closed 4 years ago

get-me-power commented 4 years ago

Hi, @kitagry ! Thanks for creating nice vim-plugin!

I used global variables to allow some values to be set on a per-user basis. Could you check this PR?

get-me-power commented 4 years ago

I fixed conflict.

kitagry commented 4 years ago

Thanks @kazukazuinaina

But, I would like to set these variables like followings.This is same as asyncomplete-buffer.vim. So, could you fix it like this?

call asyncomplete#register_source(asyncomplete#sources#tabnine#get_source_options({
  \ 'name': 'tabnine',
  \ 'allowlist': ['*'],
  \ 'completor': function('asyncomplete#sources#tabnine#completor'),
  \ 'config': {
  \   'line_limit': 1000,
  \   'max_num_result': 20,
  \ }))
get-me-power commented 4 years ago

@kitagry Thanks for review. How about this changing?

kitagry commented 4 years ago

Thanks @kazukazuinaina

get-me-power commented 4 years ago

@kitagry Thanks for your merging!