djrscally
commented
4 years ago Yeah we're doing similar work. Here's my debugging prints (only the last call to setupLink():
[1:44:31.702099031] [12553] INFO MediaDevice media_device.cpp:806 /dev/media1[ipu3-imgu]: Source: ipu3-imgu 0[devnode: /dev/v4l-subdev4], Sink: ipu3-imgu 0 output[devnode: /dev/video6]
[1:44:31.702139553] [12553] INFO MediaDevice media_device.cpp:810 /dev/media1[ipu3-imgu]: Existing link flags: 3
[1:44:31.702177422] [12553] INFO MediaDevice media_device.cpp:813 /dev/media1[ipu3-imgu]: Requested link flags: 1
[1:44:31.702212204] [12553] INFO MediaDevice media_device.cpp:816 /dev/media1[ipu3-imgu]: File descriptor: 6
[1:44:31.702276285] [12553] INFO MediaDevice media_device.cpp:838 /dev/media1[ipu3-imgu]: points to: /dev/media12212204] [12553] INFO MediaDevice
[1:44:31.702308314] [12553] ERROR MediaDevice media_device.cpp:846 /dev/media1[ipu3-imgu]: Failed to setup link: Invalid argumentIt's failing at the call to ioctl:
int ret = ioctl(fd_, MEDIA_IOC_SETUP_LINK, &linkDesc);
if (ret) {
ret = -errno;
LOG(MediaDevice, Error)
<< "Failed to setup link: "
<< strerror(-ret);
return ret;The link is flagged as Immutable already, but the flag it's setting is just an enable flag so that should be ok. So we need to figure out why it fails. I tried fetching the link to get the existing flags like this:
MediaLink *existinglink = link(nlink->source(), nlink->sink());
/* print existing links */
LOG(MediaDevice, Info)
<< " Existing link flags: " << existinglink->flags();As you can see in my debug prints above, that reports a value of 3, I.E. 00000011. Flags are here in media.h:
#define MEDIA_LNK_FL_ENABLED (1 << 0)
#define MEDIA_LNK_FL_IMMUTABLE (1 << 1)
#define MEDIA_LNK_FL_DYNAMIC (1 << 2)So, I think it's trying to enable an already enabled link. Not sure if that should matter. Alternatively, the call I make to the link function doesn't look like it performs an ioctl to get that link, so possibly it's mistaken in thinking that that exists. Might try using MEDIA_IOC_ENUM_LINKS to check for sure.
kitakar5525
Current status is, ov5693 isn't working yet.
libcameracan't get images outputting thatFailed to setup link: Invalid argument.0001-media_device-add-debug-print-in-setupLink.patch
```diff From a96cb7ece0050727e04bec30844d73156e0864c8 Mon Sep 17 00:00:00 2001 From: Tsuchiya Yuto
Date: Sat, 22 Aug 2020 23:42:53 +0900
Subject: [PATCH] media_device: add debug print in setupLink()
Signed-off-by: Tsuchiya Yuto
---
src/libcamera/media_device.cpp | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
index de18d57..e12db5e 100644
--- a/src/libcamera/media_device.cpp
+++ b/src/libcamera/media_device.cpp
@@ -802,9 +802,26 @@ int MediaDevice::setupLink(const MediaLink *link, unsigned int flags)
LOG(MediaDevice, Error)
<< "Failed to setup link: "
<< strerror(-ret);
+ LOG(MediaDevice, Error)
+ << "DEBUG: linkDesc.source.entity: " << linkDesc.source.entity;
+ LOG(MediaDevice, Error)
+ << "DEBUG: linkDesc.source.index: " << linkDesc.source.index;
+ LOG(MediaDevice, Error)
+ << "DEBUG: linkDesc.sink.entity: " << linkDesc.sink.entity;
+ LOG(MediaDevice, Error)
+ << "DEBUG: linkDesc.sink.index: " << linkDesc.sink.index;
return ret;
}
+ LOG(MediaDevice, Debug)
+ << "DEBUG: linkDesc.source.entity: " << linkDesc.source.entity;
+ LOG(MediaDevice, Debug)
+ << "DEBUG: linkDesc.source.index: " << linkDesc.source.index;
+ LOG(MediaDevice, Debug)
+ << "DEBUG: linkDesc.sink.entity: " << linkDesc.sink.entity;
+ LOG(MediaDevice, Debug)
+ << "DEBUG: linkDesc.sink.index: " << linkDesc.sink.index;
+
LOG(MediaDevice, Debug)
<< source->entity()->name() << "["
<< source->index() << "] -> "
--
2.28.0
```
Lines with
DEBUG:are added by the above patch.Below is the full debug output with
LIBCAMERA_LOG_LEVELS="*:DEBUG":