search

kitamstudios / rust-analyzer.vs

Rust language support for Visual Studio 2022
https://marketplace.visualstudio.com/items?itemName=kitamstudios.RustAnalyzer
Other
138 stars 10 forks source link

Support for specifying working directory for debugging #25

Closed Novum closed 1 year ago

Novum commented 1 year ago

This is fairly important in a lot of cases where data is expected relative to the executable path

parthopdas commented 1 year ago

💖 thank you. nicely done!

parthopdas commented 1 year ago

looking into this.

parthopdas commented 1 year ago

@Novum please can you accept the invite https://github.com/kitamstudios/rust-analyzer.vs/invitations. i've given you write access. this should solve the issue.

parthopdas commented 1 year ago

so for PRs i have disabled out the ci step that was getting access denied as it didn;t work even after i gave you admin access.

for now please can you sync master and resubmit the PR?

that should work, if not i'll force merge it and then see what it takes to get a pr from another contributor - which tbh has already happened. not sure what is different this time.

parthopdas commented 1 year ago

also added a comment to remove the .tostring as it is already a string.

parthopdas commented 1 year ago

released to vs marketplace.

Novum commented 1 year ago

image

I don't know what exactly happened, but this is with latest from the marketplace. Debugging doesn't work at all. This does not happen if I compile locally, so I'm really confused.

Novum commented 1 year ago

It also does work correctly if I install the locally compiled VSIX. I have no idea what's going on here.

parthopdas commented 1 year ago

shoot. I assume your changes were tested?

there was one other change related to #24

could you debug it please and see what the issue is?

If not I should get to this shortly.

Novum commented 1 year ago

Yes, I tested locally of course. Will get latest on your branch and check that.

Novum commented 1 year ago

I can reproduce this on latest code with a debugger, seems unrelated to my change then?

image image

string profile is null

Novum commented 1 year ago

Reverting "#24 workaround for CMake debugger being overridden by ra.vs debugger." fixes it.

parthopdas commented 1 year ago

hmm pretty positive I tested this.

I'll push in a fix by tonight.

parthopdas commented 1 year ago

@Novum pushed in a fix. i have tested both this and #24 but if you could too that will be great. as many debugging scenarios as you can : ) here is the CI build https://www.vsixgallery.com/extension/KS.RustAnalyzer.3a91e56b-fb28-4d85-b572-ec964abf8e31/

also preemptively pushing this to marketplace.

Novum commented 1 year ago

I can confirm that the CI build fixes it for my cases.

parthopdas commented 1 year ago

published to marketplace as well. thanks @Novum for your help.