kitao / pyxel

A retro game engine for Python
MIT License
15.31k stars 847 forks source link

Consider tracking Cargo.lock #555

Open TomaSajt opened 3 months ago

TomaSajt commented 3 months ago

Hello, I maintain this package on Nixpkgs and our build process requires the presence of a Cargo.lock file to build a rust project (to achieve reproducible builds)

However, pyxel's repository does not provide the lockfile, since .gitignore blacklists the lockfile from being tracked

Currently we manually generate the lockfile and include it in our repository

Would you consider providing this file?

It is generally considered good practice that you provide a Cargo.lock file for the package if your rust program is built into a binary.

Here's what the Rust FAQ says: https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

Though, I see that this repository has a multi-project rust workspace where it might be a bit more annoying to work with lockfiles