search

kitao / pyxel

A retro game engine for Python
MIT License
15.31k stars 847 forks source link

Stopped Working on Steam Deck #568

Closed edrobot closed 1 month ago

edrobot commented 1 month ago

I played a game called Dungeon Antiqua recently on my Steam Deck, which runs on the Pyxel engine. While the game worked perfectly the first few times, when I booted it up this morning, I got this error message:

File "dungeon-antiqua-tmp.py", line 1 in File "pyxel\cli.py", line 225 in play_pyxel_app File "pyxel\cli.py", line 211 in _extract_pyxel_app File "pyxel\cli.py", line 137, in _create_app_dir FileExsistsError; [WinError 183] File Already Exists 'C:\users\steamuser\Temp (The rest is cut off by the screen size.)

While it's possible this is a problem with the game's code, given the error message I suspect this is a problem with the engine's code instead.

Just to be sure I've also tried contacting the Dungeon Antiqua devs, but given that they're Japanese I have no idea if they're even going to respond. https://steamcommunity.com/app/3198540/discussions/0/6617568006280651821/

son-link commented 1 month ago

I got that message when testing the generated executable of my game on Windows, but it doesn't happen on Linux. It seems that it is where the game data is extracted, and when that temporary folder is not deleted, for whatever reason, it gives that error, but I attributed it to testing, and it was not deleted after exiting the game.

edrobot commented 1 month ago

changing the steam deck compatability options seems to have fixed it

kitao commented 1 month ago

I don't have a Steam Deck to verify, but I believe it should be fixed.

kitao commented 1 month ago

I fixed the issue in 2.2.4.

@shiromofufactory Please try to update the app with the latest version (2.2.4).

shiromofufactory commented 1 month ago

@kitao Thanks, I had a version built with ver 2.2.4 to play, and users reported that they still get the same error. Do I need to take action, such as manually deleting some files once?

GZrQiGsaAAIxWMc

kitao commented 1 month ago

It looks strange. Because I added two lines and the line number of the error should be different at least. It was at L137 in the previous version, but it is at L139 now.

https://github.com/kitao/pyxel/blob/main/python/pyxel/cli.py#L137-L139

shiromofufactory commented 1 month ago

My apologies, my mistake. I will build again and check and get back to you.

shiromofufactory commented 1 month ago

@kitao

I have confirmed that the issue has been resolved in the version built with pyxel 2.2.5. Thank you!!