search

kitar / laravel-dynamodb

A DynamoDB based Eloquent model and Query builder for Laravel.
MIT License
179 stars 27 forks source link

Update PHP Doc Block - Says MongoDB #27

Closed localpath closed 1 year ago

localpath commented 1 year ago

https://github.com/kitar/laravel-dynamodb/blob/e6c9063e368692cd22589b6791850a5010ae53ac/src/Kitar/Dynamodb/Connection.php#L70

kitar commented 1 year ago

Awthanks @localpath ! I didn't realize that.

localpath commented 1 year ago

@kitar NP. I noticed it after the new minor version. I use docker compose for local dev and my dynamoDB containers run using http so the minor version broke since I was using the shorthand reference from .env to the container. The new version adds https when I really just have http available by default on that container.

This breaks if you have dynamoDB locally running on http DYNAMODB_ENDPOINT=dynamodb:8000 Adding the protocol if you are on http fixes it DYNAMODB_ENDPOINT=http://dynamodb:8000

dynamodb:
    image: amazon/dynamodb-local
    container_name: dynamodb
    ports:
      - 8042:8000
    command: ["-jar", "DynamoDBLocal.jar", "-sharedDb", "-dbPath", "/home/dynamodblocal/data"]
    volumes:
      - deka-unified-dynamodb:/home/dynamodblocal/data
    user: root
    networks:
     - deka-unified
    restart: on-failure