search

kitasuke / PagingMenuController

Paging view controller with customizable menu in Swift
MIT License
2.5k stars 449 forks source link

Disable auto-select by swiping MenuItem on Standard mode #332

Open t opened 7 years ago

t commented 7 years ago

Related: https://github.com/kitasuke/PagingMenuController/issues/212

Please see below GIF animation, user is trying to see tab0 (the first tab) by swiping menu. but always back to tab4 by auto select and never see tab0.

Original org0

I guess most of users don't expect such behaviour on standard mode (and centerItem is false), so I don't make option, just disabled auto-select on the mode.

Fix fix0

but If you think to need to keep current behaviour, I will add option to keep it.

kitasuke commented 7 years ago

Thanks for your PR! This library is not designed for that case, so disabling auto-select is not preferred. Can you add new option instead?

t commented 7 years ago

@kitasuke sure, I will add.

t commented 7 years ago

@kitasuke Sorry for no-update long time. Finally, I added isAutoSelectAtScrollEnd option to MenuViewCustomizable