kitasuke / PagingMenuController

Paging view controller with customizable menu in Swift
MIT License
2.49k stars 448 forks source link

onMove handler lacks means to distinguish between menuItemView instances #335

Open effzehn opened 7 years ago

effzehn commented 7 years ago

It is very practical to intercept the movements of the menu items. But For the case .willMoveItem the provided menuItemView instances lack a proper way to distinguish them from each other and therefore, to find out, which page will be selected. Sure, you could compare the Title text or any other UI feature, but e.g. usage of the UIView tag would be more practical. However, using MenuItemViewCustomizable it doesn't allow the configuration of the tag (or any other UIView properties). I suggest to either allow to provide a UIView tag in the MenuItemViewCustomizable configuration or to provide a more useful associated value for the .willMoveItem case.