kitasuke / PagingMenuController

Paging view controller with customizable menu in Swift
MIT License
2.5k stars 449 forks source link

Nasty space between navbar and paginMenu #354

Open elchris78 opened 7 years ago

elchris78 commented 7 years ago

Hey there guys,

I just implemented this awesome project into of project of mine. Everything works ok, but I'm having some problem with getting rid of some nasty space between Navigation Bar and PagingMenu Bar. I want them to be together (no padding between them) but I haven't found the solution yet. It is that yellow space in the image below. The yellow is because I changed the root view's background to yellow so it can be notorious. screen shot 2017-05-24 at 6 48 01 pm

Any help on this one guys please? Thank you in advance...

elchris78 commented 7 years ago

Found the solution. It's not a bug, it's a configuration matter (or creation of the child view of the root view). You've gotta set to + - 0 the y and height properties of the pagingMenuController screen shot 2017-05-26 at 4 18 42 pm

Just to let you know...

kevinlee85 commented 7 years ago

I think "You should add ContainerView into your view controller's view and set PagingMenuController as the embedded view controller's class" should be the correct solution. You should drag one Container View to your UIViewContolller, then add your pagemenu controller to the container view. containerView.addSubview(pagingMenuController.view) The containerView is you drag in form IB.

PhilippeBoisney commented 7 years ago

Thanks @elchris78 ! You saved my day.