kitasuke / PagingMenuController

Paging view controller with customizable menu in Swift
MIT License
2.5k stars 449 forks source link

Swift 4 Version? #368

Open ThreadPitt opened 6 years ago

ThreadPitt commented 6 years ago

Hi,

great lib, thanks for your effort! Is there a Swift 4 version planned?

Cheers!

ruoyi commented 6 years ago

great lib, each time you update the podfile you want to change the compiled version of swift,Hope to support swift4

Cheers!

ankitaporwal commented 6 years ago

any plans for swift 4 support ?

ReverseScale commented 6 years ago

Actually I compiled using Swift 4.0, there is no serious mistakes, can run simple change

ThreadPitt commented 6 years ago

Yes, works for me too!

mingmingsuper commented 6 years ago

I also need for swift4 support!

mingmingsuper commented 6 years ago

When my project convert to swift4,the PagingMenuController lib must run in swift 3.2,it can't run in swift4!

pirtil commented 6 years ago

There is pull request for Swift 4 available, any plans to merge that? https://github.com/kitasuke/PagingMenuController/pull/366

termic commented 6 years ago

Doesn't support safe area in swift4, is there any one who solved this?

olgusirman commented 6 years ago

@termic Have you tried this for IOS 11? Maybe It can help

collectionView.contentInsetAdjustmentBehavior = .never

ruoyi commented 6 years ago
post_install do |installer|
  installer.pods_project.targets.each do |target|
    if ['PagingMenuController'].include? target.name
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '3.2'
        config.build_settings['ONLY_ACTIVE_ARCH'] = 'NO'
      end
      else
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.0'
        config.build_settings['ONLY_ACTIVE_ARCH'] = 'NO'
      end
    end
  end
end