RouterView as default route component

kitbagjs / router

A type safe router for vuejs

https://router.kitbag.dev

MIT License

173 stars 4 forks source link

RouterView as default route component #127

Closed stackoverfloweth closed 5 months ago

stackoverfloweth commented 5 months ago

previously, if a child route rendered RouterView it would cause infinite loop. This PR moves responsibility for defaulting component to createRoutes method.

side quests

fixes vue external dep on vite build
fixed bug with incorrect sort for matches, should be greatest ancestor -> least descendent
attempts to fix type error when using plugin (could have been related to npm link)
bumps version back to what's published on npm
moves vue to peerDep

netlify[bot] commented 5 months ago

Deploy Preview for kitbag-router ready!

Name	Link
Latest commit	172ca07f21ebb1c89740275a4452a787ee3fb186
Latest deploy log	https://app.netlify.com/sites/kitbag-router/deploys/662517c64ed8c10008a0c5f6
Deploy Preview	https://deploy-preview-127--kitbag-router.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kitbagjs / router

RouterView as default route component #127

✅ Deploy Preview for kitbag-router ready!

Deploy Preview for kitbag-router ready!