search

kitbagjs / router

A type safe router for vuejs
MIT License
131 stars 1 forks source link

Update component utility to not require suspense unless props are async #198

Closed pleek91 closed 2 weeks ago

pleek91 commented 2 weeks ago

Description

https://github.com/kitbagjs/router/pull/164 introduced the component utility which allowed binding props and attrs directly to route components. But it always required suspense because even if the props getter was not async it would wrap it in an async component.

This PR fixes that by only wrapping the component in an async component IF the getter returns a promise.

netlify[bot] commented 2 weeks ago

Deploy Preview for kitbag-router ready!

Name Link
Latest commit 162ee601bf525a4cdb14bfb3c4d1a2976bda29ac
Latest deploy log https://app.netlify.com/sites/kitbag-router/deploys/6672f20009a64f000924014b
Deploy Preview https://deploy-preview-198--kitbag-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.