kitbagjs / router

A type safe router for vuejs
MIT License
131 stars 1 forks source link

Fixed bug with host route match rule #206

Closed stackoverfloweth closed 2 weeks ago

stackoverfloweth commented 2 weeks ago

I discovered bug while trying to update our stackblitz to latest version (currently on 0.2.0). Initial routes were not passing routeHostMatches because url has localhost:5173 for host and route would have undefined.

This PR updates the logic for host match rule to treat a route without host as automatically relative and passes host check.

At some point as we expand support for external routes we can expect route to have host, however undefined will continue to be assumed as automatically relative so this change will still apply.

netlify[bot] commented 2 weeks ago

Deploy Preview for kitbag-router ready!

Name Link
Latest commit 864b5ee1bf9743ed19f99ca2915966ffa1419bb0
Latest deploy log https://app.netlify.com/sites/kitbag-router/deploys/66772c070e72b90008e0c4c4
Deploy Preview https://deploy-preview-206--kitbag-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.