search

kitbagjs / router

A type safe router for vuejs
https://router.kitbag.dev
MIT License
173 stars 4 forks source link

Add hook conditions to route level hooks #98

Closed pleek91 closed 7 months ago

pleek91 commented 7 months ago

Description

Updates the getRouteHooks method to return only hooks that should be run based on the RouteHookType

netlify[bot] commented 7 months ago

Deploy Preview for kitbag-router ready!

Name Link
Latest commit a67bc267f410714bbf9b1b3966a6a14835cb7c9c
Latest deploy log https://app.netlify.com/sites/kitbag-router/deploys/65d96ea4b7371c0008711bb1
Deploy Preview https://deploy-preview-98--kitbag-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pleek91 commented 7 months ago

@stackoverfloweth I think this is ready based on what we talked about. I didn't implement the onBeforeLocationUpdate in this PR but that will be the next piece I work on. We'll need a little more functionality in navigation to account for actually aborting navigation. So should have a fairly small PR to implement that. I also need to write tests for the component and global hooks. So this will probably be a few PRs before this is buttoned up.