search

kitchenplan / chef-applications

A cookbook, based on the pivotal_workstation, but without a lot of custom providers and a lot cleaner.
Apache License 2.0
23 stars 33 forks source link

PHP55 is too specific #107

Closed mAAdhaTTah closed 10 years ago

mAAdhaTTah commented 10 years ago

The PHP55 recipe includes a couple settings in the ini file that are specific to your company's setup. This isn't the only spot where that happens - the kstrano recipe, for example, installs your capistrano deploy scripts. I'm just wondering how we're supposed to handle some of these - is the intention that we fork and use our own chef-applications repo? Or what exactly?

Any guidance would be helpful, thanks!

roderik commented 10 years ago

Best way would be to move these settings into attributes, so you can change them in your config file. I'll gladly accept a pull request to that effect :)

mAAdhaTTah commented 10 years ago

Actually, I'm running into some minor-ish issues where any php-related formula requires the homebrew-php tap to be tapped already, and one of them (phpdoc) requires a version to be installed as well. There are a few applications in the chef-applications repo that are php-related, and I'm wondering if maybe it makes more sense to pull out the php stuff into a separate repo, a la nodejs. Thoughts?

mAAdhaTTah commented 10 years ago

Or should they all just be added here?

roderik commented 10 years ago

I’m not against splitting them out, but i’ve not seen the need as of yet.

You can however force taps to be done by adding:

homebrewalt: 
    taps:
    - homebrew/homebrew-php

Apart from that, should every recipe do everything it needs to run, even if it’s the only recipe, so recipes that need homebrew/homebrew-php but do not tap is themselves, should.

mAAdhaTTah commented 10 years ago

Yeah, so maybe it makes more sense to add them into the applications repo. I'm assuming you'd be open to PR's for new php-related recipes?

roderik commented 10 years ago

yups, send them along!

mAAdhaTTah commented 10 years ago

Great - working on it now. Just curious, but in the composer recipe, why are we installing as root? And/or why are we not installing through homebrew? Or are we? I'm new to Chef/ruby, so pardon the basic questions :).

roderik commented 10 years ago

Homebrew is better, but it didn’t exist when composer was very new

roderik commented 10 years ago

Merged everything, sorry for the wait

mAAdhaTTah commented 10 years ago

No problem, thanks!

roderik commented 10 years ago

FYI i moved to the homebrew composer version