search

kitconcept / kitconcept.dsgvo

DSGVO/GDPR Plugin for Plone
GNU General Public License v2.0
0 stars 6 forks source link

Doesn't work with Plone 4: Javascript and CSS resources not registered #19

Open tobiasherp opened 3 years ago

tobiasherp commented 3 years ago

If the add-on is installed in a Plone 4 site, there is no visible effect, because the resources are not registered. Probably the jsregistry.xml and cssregistry.xml files could simply be copied over to the plone4 profile.

BTW, are those files used at all for Plone 5? Perhaps the plone5 versions of {css,js}registry.xml could remove those resources? That way, we'd have changes in both flavours of the profile, and we could increment the profile version for both in sync.

tisto commented 3 years ago

@tobiasherp thanks for your bugreports and the PR. Let me first move the package from Travis to gh actions, to have a stable base for changes before moving on...

tobiasherp commented 3 years ago

@tisto So, is there some hope for a 1.3.1 version? Of course, I want to change to Plone 5 one happy day, but I can't just now, and I'd be happy to have the option to use kitconcept.dsgvo right now and then smoothly upgrade.

tisto commented 3 years ago

@tobiasherp I'd be willing to cut a 1.3.1 release. Though, I do not have time to put effort into this, since we are not using Plone 4 (or Plone 5 classic) any longer. We would need to get the CI running again and then merge your PRs and fixes...

tobiasherp commented 3 years ago

@tisto I understand, of course. So, if I'd be able to make the CI für Python 2.7 and Plone 4.3 run again, this would help; otherwise I'd need to use a development package.