kitconcept / kitconcept.intranet

0 stars 1 forks source link

Add person search #6

Open steffenri opened 10 months ago

steffenri commented 10 months ago

Prerequisites

Specification

Figma

https://www.figma.com/file/eYUCbivnNrnjXjBDUizSVX/Volto-Light-Theme?type=design&node-id=343-6729&mode=design&t=P4IU8MuYCbBQJk0v-0

Screenshot Listing View

intranet-profile-search_grid-with-image (1)

Screenshot Grid View

intranet-profile-search_grid-with-image (2)

steffenri commented 10 months ago

@tisto @sneridagh Are those the correct designs? I was not quite sure which one to use from the VLT.

Also: The collective.person package contains only the most basic information at the moment (https://github.com/collective/collective.person/blob/main/src/collective/person/behaviors/person.py#L34). Do we want to add things like phone,mail, etc. to the package or customize it on our side?

tisto commented 9 months ago

@steffenri @reekitconcept I'd start with a basic version that hard-codes the available facets.

Can you provide the schema for the collective.person profile? I'd like to have a basic person profile and 2-3 basic facets (that we have in all our intranet projects), e.g.:

I see the kitconcept.intranet person search as a showcase for our basic functionality. We always need to override this for client projects (like BfS) for the time being.

Making the facets fully configurable and maybe even addable/editable TTW is something we can tackle at a later point.

reekitconcept commented 9 months ago

I'm already over 50% progress with this. I agree that the facet configuration should be basic and focusing on this use case first.

TTW is not targeted under this ticket. The configuration is json and done via plone.app.registry, in the same way the search and the facets are configured but extending it. kitconcept.solr comes with sensible defaults oob, which can be overridden by the consumer. To stress out there is nothing new here, I just extend what we already use with success with kitconcept.solr.

Regarding "providing the collective person profile". What I'm doing currently is that I'm creating the collective.person profile and the facet configuration together. Once they are working according to the specification described in the ticket, I can finalize it as a PR in kitconcept.intranet. @tisto if this approach is not you have in mind, let's discuss this please!

Also note that how the final configuration in the consumer app is to be done is still unclear and we're waiting for Erico's proposal about the new dual client/server configuration scheme, for which this application will be the first user of. If Erico's proposal is however arriving later then we like, we are not depending on Erico and release as a separate packages for client and server. It's just important to stress that we are not intending to solve the dual client/server configuration under this work, rather than use something that we'll use for everything.

tisto commented 6 months ago

Things we need to do to push this further:

tisto commented 6 months ago

@ericof could you look into either:

start with whatever is faster to have something up and running we can work with.