kitconcept / volto-dsgvo-banner

MIT License
3 stars 3 forks source link

Upgrade react-ga4 in order to also support Google Analytics GA4 #10

Closed avoinea closed 1 year ago

avoinea commented 1 year ago
davisagli commented 1 year ago

@sneridagh Will this cause any problem for our projects? I am not sure if we have some that are using Google Analytics. If we do, they need to be updated to GA4 anyway, because Google is deprecating the old one.

avoinea commented 1 year ago

@davisagli react-ga4 should also work with UA-. See https://github.com/react-ga/react-ga/issues/493#issuecomment-865316243

davisagli commented 1 year ago

@avoinea ah, so it is a different library that adds support for GA4 but does not remove support for old Analytics. Cool.

avoinea commented 1 year ago

@davisagli In theory :smile: Please test it first with UA-. I only have GA4

sneridagh commented 1 year ago

@avoinea I just saw the PR :( sorry, could you update it to add a towncrier news item? I can release afterwards. Thanks! Make sure you update the lock too!

avoinea commented 1 year ago

@sneridagh Ski vacation here. Will do next week if no one will take it until then 😉

steffenri commented 1 year ago

@avoinea What's the status here? Would be great to have this released soon! :)

sneridagh commented 1 year ago

@avoinea ping me if you want to move things forward with this one!

avoinea commented 1 year ago

@sneridagh I fixed the PR, added changelog.

You should consider upgrading to react-ga4 2.1.0 https://www.npmjs.com/package/react-ga4

sneridagh commented 1 year ago

@avoinea thanks!