Add more options - Githubissues

kitconcept / volto-dsgvo-banner

MIT License

3 stars 3 forks source link

Add more options #24

Closed Molochem closed 8 months ago

Molochem commented 8 months ago

I've added some more Options for customizability :

The Ability to customize the CSS classes of the Modal Buttons and the Block Button
The Option to disable the Pop-Up of the Banner on the first Connect of the User
The Option to hide the Disabled "Technically Required" Checkbox in Banner and Block

Also I have added the supported Modules to the README.md and updated it to encompass the Options I've added

Fixes #22

Molochem commented 8 months ago

@davisagli I've added the requested Features, please review again and then merge if everything is okay

Molochem commented 8 months ago

@davisagli Tests are a go

davisagli commented 8 months ago

@Molochem I added a few more requests.

I also made a new branch of kitconcept.com to test it with this branch of volto-dsgvo-banner and without the customizations that were there before: https://github.com/kitconcept/kitconcept.com/compare/davisagli-social-blocks?expand=1 -- it seems to be working well. My branch will need to be updated to use a new release of volto-dsgvo-banner once this PR is merged and released.

Molochem commented 8 months ago

@davisagli Let me now what you think about the Readme Entry, im not quite sure if its good