search

kitconcept / volto-light-theme

https://light-theme.kitconcept.io
11 stars 8 forks source link

Background color goes full width #323

Open sneridagh opened 8 months ago

sneridagh commented 8 months ago

While working in kitconcept.com site, I realised that there was a CSS rule in place that was preventing the widths of the blocks main wrapper go further layout width. This was fine for now, because it's what we wanted in VLT and complied with the mocks. But then, since in .com we want them to go side to side I "fixed" it. However, the grouping now works as expected and extends the div until the end by default.

Question is, we can configure this (easily, at several levels), but we have to decide what's the default.

@tisto What do you think? To see it in action, https://light-theme.kitconcept.io/ now has the wide version. Remember, we are in alpha in VLT still.

/cc @davisagli @danalvrz

image
tisto commented 8 months ago

@sneridagh awesome! I'd make the full width the new default. I think this is in sync with what TB would prefer. Please ask him via Figma to confirm this.

danalvrz commented 8 months ago

@sneridagh on a 14in screen I wouldn't have noticed the improvement, but I think it looks a lot better for wider screens. Sounds good as new default! Having the "non-full-width" BG color be narrower (enough to be noticeable on smaller screens), might be worth looking into.

sneridagh commented 8 months ago

ok! Decided then. I added a breaking notice in the changelog.