search

kitconcept / volto-light-theme

https://light-theme.kitconcept.io
11 stars 8 forks source link

make font definition maps use variables #372

Closed erral closed 3 months ago

erral commented 5 months ago

See #371 for the original idea

sneridagh commented 4 months ago

@erral Regarding this one, we decided back in the day that the main VLT feature are the special curation of the typography and the vertical spacing used. They are quite inter-related and makes no sense to make them easy to change them. Then VLT looses all his reason to be.

Also, VLT does not aim to be a full blown design system, nor a CSS framework. But this thin layer where the relationships between blocks and text are well defined and curated.

Another thing is to make it easy to override (like your other PR), which we should make easy to do, but I don't think that bloat VLT with variables and make it super configurable is the way to go. We can discuss about it in the next Volto Team meeting.

sneridagh commented 3 months ago

@erral I would close this one if you don't mind.