search

kitconcept / volto-light-theme

https://light-theme.kitconcept.io
12 stars 9 forks source link

Make Volto requirements more explicit. #400

Closed fredvd closed 5 months ago

sneridagh commented 5 months ago

@fredvd I don't think that we did nothing breaking that would make 4.x not work with Volto 17.

fredvd commented 5 months ago

I tried it in a 17 project by pinning 4.0.0 and it fails. Iirc something with not finding ‘@plone/components’. That’s why I started looking for more info. I can give you the exact error if you want to see it.

sneridagh commented 5 months ago

@fredvd uh, I see the problem now... I will fix it.

sneridagh commented 5 months ago

@fredvd now should be fine, can you test it using 4.0.1? Now the dependencies are ok:

32  "dependencies": {
33    "@plone/components": "2.0.0-alpha.11"
34  },
sneridagh commented 5 months ago

@fredvd I added this https://github.com/kitconcept/volto-light-theme/pull/405/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R235 to the other PR, that will supersed this one.

sneridagh commented 5 months ago

@fredvd I confirmed that using 4.0.1 package it does work with Volto 17. I am introducing a new requirement though, when merging #405. Volto 17.18.1 at least, so I will issue a new breaking in there to make it noticeable.